Skip to content

Conversation

@irexyc
Copy link
Collaborator

@irexyc irexyc commented Sep 9, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lzhangzz lzhangzz self-requested a review September 23, 2025 05:46
@lvhan028 lvhan028 marked this pull request as ready for review October 30, 2025 13:38
@lvhan028 lvhan028 changed the title [WIP] support context parallel support context parallel Oct 30, 2025
@lvhan028 lvhan028 added the enhancement New feature or request label Oct 30, 2025
@lvhan028
Copy link
Collaborator

lvhan028 commented Nov 3, 2025

may resolve the build error on windows platform

const int tp_rank_;
const DataType data_type_;
const bool debug_;
const bool is_driver_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming is_driver_ to be more specific. The current name is vague - what exactly is it driving or controlling?

Tensor symm_logits_buf_;

// context parallel
Tensor_<float> symm_cp_ML_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "ML" indicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants